Push to master#41
Merged
Merged
Conversation
These env vars should also be updated in `infrastructure` and `helm-charts`.
…e-level tracing) We should've done this from the start. Now I have to add "context.Context" to every single service method (maybe even repo method!) and fix the tests! AAARGHH!!
They need a context. So the service method that calls them needs a context too. So the tests need to be updated. Don't forget to pass the context when mocking! We should've added a context from the very start. It's gonna be a huge pain to rewrite everything...
My goal is to migrate from Event and Eventf to using Info/Debug/Warn/Error.
I changed the base in my PR (accidentally set it to master instead of develop) which cancelled the jobs. This PR is used to trigger the Github Actions bot again.
See commit 1c0f39b in room-service for a description.
I also replaced 'Pending' with 'Active' in `GetPendingGuestReservations`, as it seemed to provide more consistency with `GetActiveHostReservations`. *Tests also need to be updated.
I need to use it so the integration tests pass.
This is possible since `room-service` has been discarded (no effective changes), and `reservation-service` has already been merged.
…logical deletion
|
Vasilijez
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.