Feature sonarqube#38
Merged
Merged
Conversation
|
magley
added
the
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
My process of adding SonarQube analysis:
book-emuser-serviceIt fails a lot because branch analysis works only on the main branch (
master) for Free accounts. As for this PR, it failed initially (Quality Gate wouldn't pass because it found a Security HotSpot within the sonarqube workflow file, but I manually makred it as safe and then it passed):Obviously that's not what you're supposed to do, but the project spec only requires us to have code analysis on one microservice, so here it is.