Initial setup#2
Merged
Merged
Conversation
Vasilijez
approved these changes
Jul 22, 2025
Vasilijez
left a comment
Member
There was a problem hiding this comment.
You established a nice initial setup.
Regarding "test coverage report artifacts (do we need this?)", I guess we should check with the assistant. I'm ready to send him a message about it.
Member
|
I only have read access, which is why my review approval didn’t count. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial setup of the user microservice.
It includes dockerization, connecting to PostgreSQL and a simple workflow that tests the app and builds it. It doesn't deploy to DockerHub because I didn't bother setting up semantic versioning and all that stuff.
Build and run using docker compose.
To test the server, run
curl http://localhost:8080/pingfrom a different terminal. It should return "Pong!".You can also do automatic testing via
run-tests.shwhich is a stub for now. You need bash to test it (so Linux or Git Bash or WSL (not recommended because of line ending differences, I couldn't get it to work)). I could add a Powershell script too, but the CI/CD workflow will only use.sh.Things I have added:
Things I haven't added:
Also, apparently, the
paths:field in github actions workflows checks for the entire PR, and not just the commit. That's why b8bca1e triggered the Actions to run even if it changed only a.mdwhich doesn't matchpaths: