Feature continuous deployment#11
Merged
Merged
Conversation
The cache in Dockerfiles is build cache and cannot be used during runtime. Adding a named volume to the package directory will speed things up in subsequent test runs. I'm not sure if this will work remotely, but it doesn't matter. This is for dev.
Because Alpine refuses to run scripts if they are CLRF, saying that the file is not found.
I still need to fix user-service ending if database is not set up, as well as have the test-runner wait for user-service (like it does for the database).
Since alpine doesn't have curl installed, I used wget to submit a health check.
magley
added
the
feature
Not sure if this will work. Also, the keys seem to be missing in the repo settings? Did I forget to add them, or were they removed...?
Because deployment should happen on push to dev/master and not during pull requests.
Vasilijez
reviewed
Aug 1, 2025
Vasilijez
left a comment
Vasilijez
left a comment
Member
There was a problem hiding this comment.
Nice work. It's really interesting to see how the integration tests are performed.
Vasilijez
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD implemented.
Check README.md on how to run integration tests properly.
Some notes:
:${VERSION:-localDevDefault}is used to capture the version when building. It usesVERSIONfrom the environment. If it's not set, then the tag will belocalDevDefault.docker compose updevelop. This is to reduce usage of free Actions minutes per month (I'm not sure how much we'd have to run CI/CD workflows for this to matter...)