Hybridise the legacy plugins#400
Merged
Merged
Conversation
This means Connectivity can be called from Python on a Dataset and IJ Macro with an open image, and IJ GUI. The under the hood behaviour is all legacy IJ1. ImagePlus based.
Put Hybrid Connectivity in the menu with no submenu.
This means that Purify can be called headless from Python using scijava Datasets as input and output.
This is now a hybrid plugin with both IJ1 run(String arg) and IJ2 run() methods.
Uses Dataset for image IO and the modern results table.
The logic is all still the same, just with scijava handling IO and options, and ImagePlus being used under the hood.
Also remove AWT dialog listeners. The legacy dialogs were essentially unreachable and more or less pointless to include. Main benefit was marginally better UX in the GUI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the legacy plugins to expose a modern API (@parameters, ImgLib scijava ImageJ2) to be friendlier to Python callers, while maintaining the legacy behaviour. Essentially, use
Datasetfor input and output andImagePlusunder the hood.