Skip to content

revisions_count: implement pagination for metadata revisions#1409

Open
gnzng wants to merge 2 commits into
bluesky:mainfrom
gnzng:fix-1389-revisions-pagination
Open

revisions_count: implement pagination for metadata revisions#1409
gnzng wants to merge 2 commits into
bluesky:mainfrom
gnzng:fix-1389-revisions-pagination

Conversation

@gnzng

@gnzng gnzng commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This PR closes #1389 (@genematx).

The revisions endpoint used the current page size as the count, so meta.count was just len(data) and the next pagination link was never generated.

Add CatalogNodeAdapter.revisions_count() (a COUNT query) and use it as the length hint in construct_revisions_response.

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

gnzng and others added 2 commits June 15, 2026 10:05
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@checkmarx-gh-ast-us-povs

checkmarx-gh-ast-us-povs Bot commented Jun 15, 2026

Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Details36d08141-642d-4038-96f4-a13ed275de79

Great job! No new security vulnerabilities introduced in this pull request


Communicate with Checkmarx by submitting a PR comment with @Checkmarx followed by one of the supported commands. Learn about the supported commands here.

@danielballan danielballan requested a review from genematx June 17, 2026 12:28

@danielballan danielballan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnzng! Looks good. I'll let @genematx get a look before this goes in. (Might be next week.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisions 'next' pagination link is never generated

2 participants