Skip to content

fix(relay): fail startup on invalid operator listener config - #7933

Merged
jsibbison-square merged 1 commit into
mainfrom
jsib-260928-fail-fast-invalid-listener-config
Sep 28, 2026
Merged

jsibbison-square merged 1 commit into
mainfrom
jsib-260928-fail-fast-invalid-listener-config

Conversation

@jsibbison-square

@jsibbison-square jsibbison-square commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Addresses point 3 of previous comment "3. Fail fast on a bad BUZZ_OPERATOR_LISTENERS (config.rs:857)"

Summary

  • Propagate malformed BUZZ_OPERATOR_LISTENERS values from Config::from_env as ConfigError, including invalid UTF-8.
  • Update startup config tests to assert returned errors and restore the original admin warning capture helper, removing the shared helper introduced only for listener log assertions.
  • Cover valid and absent listener values through Config::from_env.

Context

Follow-up to the review of #7793 specifically reverting some config logging parts. Invalid listener configuration currently logs an error and silently disables listener delivery.

Verification

  • cargo fmt --all -- --check passed with Hermit.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is c4c86006f2d67b2ea9055780129ee7ce95c54e0a...26b6ae77a9d172d37a31041043b1bbe542b047fa.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 26b6ae77a9d172d37a31041043b1bbe542b047fa to authorize a new review.
Any previous review applies only to its recorded range.

@jsibbison-square
jsibbison-square force-pushed the jsib-260928-fail-fast-invalid-listener-config branch from 67b105a to f665574 Compare September 28, 2026 04:06
Signed-off-by: Implementor <691cca7a870db1dad6990d5938d1b4a2a2ca9647ca81290b536c17b06b2e473f@buzz.block.builderlab.xyz>
@jsibbison-square
jsibbison-square force-pushed the jsib-260928-fail-fast-invalid-listener-config branch from f665574 to 26b6ae7 Compare September 28, 2026 04:45
@jsibbison-square
jsibbison-square marked this pull request as ready for review September 28, 2026 05:42
@jsibbison-square
jsibbison-square requested a review from a team as a code owner September 28, 2026 05:42
@jsibbison-square
jsibbison-square merged commit ebe99a4 into main Sep 28, 2026
88 checks passed
@jsibbison-square
jsibbison-square deleted the jsib-260928-fail-fast-invalid-listener-config branch September 28, 2026 13:18
wpfleger96 pushed a commit that referenced this pull request Sep 28, 2026
Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>

* origin/main:
  fix(relay): fail startup on invalid operator listener config (#7933)
  fix(db): limit event transactions to listener mention kinds (#7932)
  feat(relay): deliver pubkey mentions to relay companions (#7793)
  docs(protocol): propose simplified channel artifacts (#7791)
  feat(push): support configurable HTTP(S) delivery URLs (#7877)
  fix(ci): select runtime suites from PR changes only (#7843)
  test(desktop): synchronize upload edit smoke test (#7903)

Signed-off-by: Hayt <211b96e6a2b7f45fd4047988976c7bbbeeda0c15f3ae7b32eec20834b5a55118@buzz.block.builderlab.xyz>
wpfleger96 pushed a commit that referenced this pull request Sep 28, 2026
* origin/main:
  🤖 docs(nip-fi): remove implementation references from the spec (#7912)
  fix(relay): fail startup on invalid operator listener config (#7933)
  fix(db): limit event transactions to listener mention kinds (#7932)
  feat(relay): deliver pubkey mentions to relay companions (#7793)
  docs(protocol): propose simplified channel artifacts (#7791)
  feat(push): support configurable HTTP(S) delivery URLs (#7877)
  fix(ci): select runtime suites from PR changes only (#7843)
  test(desktop): synchronize upload edit smoke test (#7903)

Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants