fix(relay): allow deleting an archived channel - #7859
Closed
BachirSaaS wants to merge 1 commit into
Closed
BachirSaaS wants to merge 1 commit into
BachirSaaS wants to merge 1 commit into
Conversation
🔐 Codex Security Review
|
An archived channel (e.g. an ephemeral huddle expired by the reaper) could never be deleted: both the admin-event validator and the ingest archive gate only excepted kind:9002 unarchive, so kind:9008 delete returned 400 'invalid: channel is archived' and the channel was stranded in the owner's list forever (block#2954, block#7596). 'Archive then delete' is the natural flow — allow kind:9008 through both guards alongside the existing unarchive exception. Desktop's unarchive (kind:9002 with archived=false) already matches the accepted shape; only the delete half was broken. Signed-off-by: BachirSaaS <bachir.dagodi@gmail.com>
BachirSaaS
force-pushed
the
fix/archived-channel-delete
branch
from
September 24, 2026 01:17
88770a4 to
1affa64
Compare
Author
|
Closing — we'll maintain these fixes in our fork instead. Thanks for the look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An archived channel (e.g. an ephemeral huddle expired by the reaper) could never be deleted: both the admin-event validator (
side_effects.rs) and the ingest archive gate only excepted kind:9002 unarchive, so a kind:9008 delete returned400 invalid: channel is archivedand the channel was stranded in the owner's community list forever (#2954, delete half of #7596)."Archive then delete" is the natural flow — this allows kind:9008 through both guards alongside the existing unarchive exception. Desktop's unarchive (kind:9002 with
archived=false) already matches the accepted shape; only the delete half was broken.Testing
cargo test -p buzz-relay --lib side_effects::green; the DB-gated ingest suites run in CI.Fixes #2954
Fixes #7596