Add opt-in bundled Goose runtime for macOS - #7858
Draft
salman1993 wants to merge 2 commits into
Draft
salman1993 wants to merge 2 commits into
salman1993 wants to merge 2 commits into
Conversation
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
🔐 Codex Security Review
|
Contributor
Author
Signed-off-by: Salman Mohammed <smohammed@squareup.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Add Goose (bundled) as an opt-in local runtime for internal macOS builds. Keep existing Goose unchanged and Buzz Agent as the default. No saved agents are migrated.
Build
goose-acpfrom a pinned upstream commit using the lean profile with native TLS and keyring support. Resolve the bundled executable from the app, and accept build-supplied provider/model defaults below explicit user choices. Model discovery preserves the configured default until the user chooses another model. Remote deployment is rejected for this local-only pilot.The existing Goose configuration and credential locations are shared. This pilot does not establish parity for upstream shell cancellation or output limits.
Related issue
Related to #7742
Testing
Onboarding screenshot showing both Goose choices.
just bundled-goose: built the pinned Apple Silicon artifact, about 15 MiB; only system dynamic-library dependencies.BUZZ_TEST_GOOSE_ACPset to the staged binary andBUZZ_TEST_BIN_DIRset to the built Buzz binaries,cargo test -p buzz-acp real_goose_native_git_shell -- --ignored --nocapturepassed. The real Goose process used a scripted local provider and verified signed commits/tags, identity, credential scope, and key cleanup.BUZZ_BUILD_BUNDLED_GOOSE_PROVIDER=databricks_v2 BUZZ_BUILD_BUNDLED_GOOSE_MODEL=goose-gpt-5-6-sol cargo test --manifest-path desktop/src-tauri/Cargo.toml --features bundled-goose --libpassed. Focused regressions also cover settings-display precedence for explicit and inherited model/provider choices.The model-discovery regression was reproduced locally before the fix: a competing catalog entry replaced the bundled default. The strengthened test waits for that entry to appear before checking the default. All 27 onboarding tests and the full local
just cigate passed after the fix.Signed app packaging, Intel macOS, and live Databricks/relay use still need qualification in the internal build.
Generated with Codex