fix(desktop): forum deep links open the target post, not the post list - #7857
Closed
BachirSaaS wants to merge 1 commit into
Closed
BachirSaaS wants to merge 1 commit into
BachirSaaS wants to merge 1 commit into
Conversation
🔐 Codex Security Review
|
A buzz://message deep link into a forum channel navigated to the base
channel route, which passes selectedPostId={null} — the forum view
rendered the post list and the target post was never opened (block#7315).
In-app navigation worked because it targets the /posts/$postId subroute.
When the active channel is a forum and a target message arrives on the
base route, redirect (replace) to the post subroute. The post id comes
from the explicit thread root when the link carries one; otherwise it is
derived from the fetched target event's own thread reference (its root
is the post), with the target passed as replyId so the thread scrolls to
it.
Signed-off-by: BachirSaaS <bachir.dagodi@gmail.com>
BachirSaaS
force-pushed
the
fix/desktop-forum-deeplink
branch
from
September 24, 2026 01:17
73ab68b to
0e75e95
Compare
Author
|
Closing — we'll maintain these fixes in our fork instead. Thanks for the look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
buzz://messagedeep link into a forum channel navigated to the base channel route, which passesselectedPostId={null}— the forum view rendered the post list and the target post was never opened (#7315). In-app navigation worked because it targets the/channels/$channelId/posts/$postIdsubroute.When the active channel is a forum and a target message arrives on the base route, redirect (
replace) to the post subroute:replyIdso the thread scrolls to itTesting
pnpm exec tsc -bclean; deep-link paths covered by the existinguseMessageDeepLinksrouting (unchanged — the fix is downstream of it, where channel type is known).Fixes #7315