Skip to content

fix(desktop): forum deep links open the target post, not the post list - #7857

Closed
BachirSaaS wants to merge 1 commit into
block:mainfrom
BachirSaaS:fix/desktop-forum-deeplink
Closed

BachirSaaS wants to merge 1 commit into
block:mainfrom
BachirSaaS:fix/desktop-forum-deeplink

Conversation

@BachirSaaS

Copy link
Copy Markdown

Summary

A buzz://message deep link into a forum channel navigated to the base channel route, which passes selectedPostId={null} — the forum view rendered the post list and the target post was never opened (#7315). In-app navigation worked because it targets the /channels/$channelId/posts/$postId subroute.

When the active channel is a forum and a target message arrives on the base route, redirect (replace) to the post subroute:

  • post id comes from the explicit thread root when the link carries one
  • otherwise it is derived from the fetched target event's own thread reference (its root is the post), with the target passed as replyId so the thread scrolls to it
  • keyed per channel+target so re-renders never double-fire

Testing

pnpm exec tsc -b clean; deep-link paths covered by the existing useMessageDeepLinks routing (unchanged — the fix is downstream of it, where channel type is known).

Fixes #7315

@BachirSaaS
BachirSaaS requested a review from a team as a code owner September 24, 2026 00:28
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is d01e5f82058463709a22e93bb4cd795da5f53e10...0e75e95c3e837fd655366d7388b1c035c2a21866.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review 0e75e95c3e837fd655366d7388b1c035c2a21866 to authorize a new review.
Any previous review applies only to its recorded range.

A buzz://message deep link into a forum channel navigated to the base
channel route, which passes selectedPostId={null} — the forum view
rendered the post list and the target post was never opened (block#7315).
In-app navigation worked because it targets the /posts/$postId subroute.

When the active channel is a forum and a target message arrives on the
base route, redirect (replace) to the post subroute. The post id comes
from the explicit thread root when the link carries one; otherwise it is
derived from the fetched target event's own thread reference (its root
is the post), with the target passed as replyId so the thread scrolls to
it.

Signed-off-by: BachirSaaS <bachir.dagodi@gmail.com>
@BachirSaaS
BachirSaaS force-pushed the fix/desktop-forum-deeplink branch from 73ab68b to 0e75e95 Compare September 24, 2026 01:17
@BachirSaaS

Copy link
Copy Markdown
Author

Closing — we'll maintain these fixes in our fork instead. Thanks for the look.

@BachirSaaS BachirSaaS closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop: buzz://message deep links into forum channels open the post list, never the post

1 participant