feat(forum): agents hear and answer forum posts and comments - #7855
Closed
BachirSaaS wants to merge 1 commit into
Closed
BachirSaaS wants to merge 1 commit into
BachirSaaS wants to merge 1 commit into
Conversation
🔐 Codex Security Review
|
BachirSaaS
force-pushed
the
feat/forum-agent-participation
branch
from
September 24, 2026 01:14
83fd99b to
27ea7b7
Compare
Forum channels were invisible to the agent surface: buzz-acp's Mentions subscription only carried kinds 9/approval/reminder, so a forum post or comment that p-tagged an agent never started a turn (block#2850, block#5268, block#4482, block#5249) — and when an agent did reply via 'buzz messages send', the CLI published kind 9, which the forum view never renders: the reply vanished (block#3828) and bare forum-channel sends were silently invisible (block#5075). Read side: forum post (45001) and comment (45003) kinds join the Mentions default subscription in one shared default_mention_kinds() helper (startup rules, per-channel filters, dynamic channel filters). The dispatch path is already kind-agnostic, and forum comments carry NIP-10 thread tags, so the existing --reply-to reply instruction fires for them unchanged. Write side: 'buzz messages send' without an explicit --kind now resolves the channel's kind:39000 metadata; in a forum channel a bare send becomes a post (45001) and a --reply-to send becomes a comment (45003). The routing lookup fails open to stream behavior on any error so it can never block delivery. Agents that follow the existing --reply-to instruction now land as visible forum comments with no prompt changes. Signed-off-by: BachirSaaS <bachir.dagodi@gmail.com>
BachirSaaS
force-pushed
the
feat/forum-agent-participation
branch
from
September 24, 2026 01:17
27ea7b7 to
962d5b7
Compare
Author
|
Closing — we'll maintain these fixes in our fork instead. Thanks for the look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forum channels were invisible to the agent surface, two ways:
Mentionssubscription only carried kinds 9 / approval / reminder, so a forum post or comment that p-tagged an agent never started a turn — the mention was silently dropped ([Bug] Forum-post @mentions never wake agents — only kind 9 chat messages reach the agent harness #2850, buzz-acp: subscribe=mentions never receives forum-post mentions (kinds 45001/45003) #5268, buzz-acp does not start agent turns for p-tagged mentions in forum thread replies #4482, Forum thread mentions never reach managed agents #5249).buzz messages send, the CLI published kind 9, which the forum view never renders: the reply disappeared from the thread ([Bug] Agent forum replies publish as kind 9 and disappear from the forum thread #3828), and bare forum-channel sends were silently invisible (buzz messages send defaults to an invisible stream event for forum roots #5075).Read side (buzz-acp)
default_mention_kinds()helper, replacing the three divergent copies (startup rules, per-channel filters, dynamic channel filters).--reply-toreply instruction already fires for them.Write side (buzz-cli)
buzz messages sendwithout an explicit--kindresolves the channel's kind:39000 metadata; in a forum channel a bare send becomes a post (45001) and a--reply-tosend becomes a comment (45003).--reply-toinstruction now land as visible forum comments with no prompt changes.--kindstays authoritative.Testing
cargo test -p buzz-acp --lib— new asserts pin forum kinds intest_mentions_mode_default_kinds+ newtest_dynamic_mentions_mode_default_kinds(963 pass; the 2lazy_poolfailures also fail on cleanorigin/main).cargo test -p buzz-cli --lib messages::— newchannel_type_from_metadata_reads_t_tag; the two palette-RTT tests updated for the one routing lookup (36 pass).Fixes #2850
Fixes #5268
Fixes #4482
Fixes #5249
Fixes #5075
Fixes #3828