Repository navigation
test(desktop): stabilize keyboard community reorder - #4652
kiranmagic7 wants to merge 3 commits into
Conversation
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
|
Re-checked the current head Review focus is the one-file Playwright synchronization in |
…keyboard-reorder-flake Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
Signed-off-by: kiranmagic7 <262980978+kiranmagic7@users.noreply.github.com>
|
Current main now covers this with stronger event-based synchronization in #8023: it waits for KeyboardSensor activation ( |
Summary
Wait one browser timer tick after the keyboard drag is picked up and before sending
ArrowUp.@dnd-kit'sKeyboardSensorcallshandleStart()synchronously, then installs its documentkeydownlistener insidesetTimeout. Pick-up state is already visible during that gap, so waiting foraria-pressedcannot prove that the listener is ready. Crossing the macrotask boundary directly closes the race. Product behavior is unchanged.Related issue
Fixes #4530. The source-derived mechanism and independent evidence are documented in #6007; that issue also tracks three separate flakes outside this PR.
Testing
On current
upstream/main(d8281b9c9), the isolated test failed 18/30 runs with retries disabled.With this patch, the isolated test passed 60/60 runs with retries disabled:
just ciScreenshots are not applicable; this is a test-only change.