[jameskraus]

Summary

The voice-notes fixture answers every upload with the demo voice note's metadata, including type: "video/mp4". When voice-notes › "rejects a full attachment draft before opening the microphone" attaches ten .txt files, each draft therefore gets a <video preload="metadata"> preview (ComposerAttachments.tsx). Those previews make 10–20 /api/relay/media loads through the file's page.route handler, which calls page.evaluate and route.fulfill.

Nothing waits for those loads. When one is still in its handler as the test finishes, the test fails with "page.evaluate: Test ended." while running route callback. On main this failed WebKit 6/6 in 38443596151, 38450152226 and 38453858017.

Change

uploadAttachment in tests/fixtures/voice-notes.tsx returns the demo metadata only for audio files, which is how recordings upload (audio/wav). Other files keep their own type, so plain attachments render as file rows and start no media loads. Recordings, assertions and the route are unchanged.

Tests

• No browser cases added or removed. One fixture function changes.
• Local media loads during the full-draft test, with request logging in an uncommitted scratch copy, measured in both WebKit and Chromium:
  • With the current fixture: 10–20.
  • With this change: 0.
• bin/pnpm test:browser --project webkit --project chromium --no-deps tests/browser/voice-notes.spec.mjs --repeat-each=2 passes 20/20 on current main, including the @media-recorder cases.

Stack

This PR → #997 → #989.

Readiness

• Agent review (no blockers)
• Hosted CI green
• Human check

Known gaps

• The race needs a slow runner to fail. Locally the evidence is that the media loads no longer happen, not a reproduced failure.

[wesbillman]

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

No blockers. The fix targets the right thing: recordings upload as audio/wav (useVoiceNoteRecorder.ts:170), so they keep the demo voice metadata. The ten .txt drafts now stay text/plain and render as file rows, so they make no /api/relay/media requests. The full-draft test still proves the limit: 10 Ready rows, the limit message, and no mic start. Hosted CI is green at 7bcd41f1.

Non-blocking:

• One wording nit, inline.
• The page.route handler in the spec's beforeEach can still throw Test ended if a future test finishes with a media load in flight. An afterEach calling page.unrouteAll({ behavior: "ignoreErrors" }) (Playwright 1.63 supports it) would cover that whole class. Fine as a follow-up.

[wesbillman]

Nit: the loads this avoids aren't voice-note loads. A draft row's voice comes from the recording (attachment-draft.ts:288), not from the upload result, so the old .txt drafts never rendered as voice-note cards. They came back as video/mp4 and got the <video preload="metadata"> preview (ComposerAttachments.tsx:225), which loads through the media route. Maybe:

// Only recordings come back as voice notes. Other files keep their own type,
// so they don't get video previews that load media.

The PR description says "voice-note preview" as well.