Repository navigation
test(workflows): give the two-draft discard journey a 15s timeout - #901
wesbillman wants to merge 1 commit into
Conversation
The same-revision discard test drives two full user-event editor journeys. It takes ~1.5s locally but timed out at the 5s Vitest default on loaded CI workers, failing main (run 38209245404) and PR #850 (run 38281787741) without a product change. Co-authored-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
No actionable changes requested: the 15-second per-test deadline preserves both discard journeys and every assertion without changing production behavior. The current CI shard completed this test in 5.253s with all 22 file tests passing; the two cited historical runs hit the former 5s deadline, supporting this narrowly scoped adjustment rather than establishing that all flakes are gone.
Star Lord automated source review via Wes’s account — head 44d6f54f615c35c9111b2e8da7a35634b10b7ec7, base a8a5ba15625b39fecc1647b1604249eccefce95b. Source-only: no local tests or app execution; CI evidence is from the PR merge snapshot, with Windows validation skipped.
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
🤖 No code defects, but this PR is now superseded and should be closed rather than merged.
#911 (fa03be63) landed on main with the same 15s timeout on this same test (}, 15_000);), plus user.paste for the Value input. This branch now conflicts with main in WorkflowsPage.test.tsx, and a rebase would leave an empty diff.
Exit criterion: close as superseded by #911.
Carl, an automated reviewer, commenting via Wes's GitHub account. Reviewed head 44d6f54f615c35c9111b2e8da7a35634b10b7ec7 against main 55b71bf1db0ff6f5700dafc0d9f347a7d52ec8ed.
|
🤖 Closing: superseded by #911, which landed the same 15s timeout plus the paste speedup. |
Summary
WorkflowsPage.test.tsx› "discards form-only state on same-revision review and re-arms the next draft's guards" runs two complete user-event editor journeys. It takes about 1.5s locally, but on loaded CI workers it goes over Vitest's 5s default. That has failed CI with no product change:This change gives that one test a 15s timeout. I left the journey itself alone: the two passes are deliberate, since they check that replacement keys are fresh. I tried swapping
user.typeforuser.paste, but it only saved about 20%, so it wouldn't fix the flake by itself.Validation
vitest run src/bundled/workflows/WorkflowsPage.test.tsx: 22/22 pass.🤖 Generated with Claude Code