Repository navigation
Conversation
…first A full discovery pass applies the viewer's rosters before it reads channel names. A channel admitted by its roster alone has no creator or labels yet, and findLabeled skipped re-reading it because the store already authorized it. A lookup in that window returned nothing. findLabeled now asks resolve to read authorized channels whose metadata has not arrived. Search and membership hints keep the old filter. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
loganj
force-pushed
the
larry/system-channel-lookup
branch
from
October 18, 2026 04:12
ac3cf92 to
66bcdd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Details
findLabeledpasses a newunnamedflag toresolve, which then also reads authorized channels whose metadata has not arrived. The flag is local to the lookup because search and membership hints rely on the existing filter (their tests read exactly the channels they expect).Related issue
None found. Found while testing system channels on staging.
Testing
store-discovery.test.tsputs the store in that window (roster known, metadata not yet read) and checks the lookup finds the channel. It fails without the fix.