Skip to content

Fix MinGW doctest compile error and quote GDK path in CI#696

Open
Bioblaze wants to merge 1 commit into
blazium-devfrom
fix/ci-mingw-doctest-gdk-path
Open

Fix MinGW doctest compile error and quote GDK path in CI#696
Bioblaze wants to merge 1 commit into
blazium-devfrom
fix/ci-mingw-doctest-gdk-path

Conversation

@Bioblaze

Copy link
Copy Markdown
Member

Summary

  • Replace bare-string WARN(...) with MESSAGE(...) in multiuser_editor JWT tests to fix MinGW -Werror=address build failure.
  • Quote gdk_path when writing to GITHUB_ENV so GDK paths with spaces resolve correctly.

Test plan

  • Windows CI Template w/ GCC matrix passes
  • Windows CI Xbox Module matrix passes GDK discovery

@sshiiden sshiiden added this to the Release 0.6.X milestone Jun 20, 2026
@sshiiden sshiiden added the enhancement New feature or improvement label Jun 20, 2026
jss2a98aj
jss2a98aj previously approved these changes Jun 21, 2026
…ves.

Replace bare-string WARN with MESSAGE in JWT tests, quote GDK paths in CI,
scope GDK headers to xbox_module, use response files and mslink-style LINKCOM
with 8.3 MSVC link.exe paths for Git Bash, and expand the Windows CI matrix.
@Bioblaze Bioblaze force-pushed the fix/ci-mingw-doctest-gdk-path branch from f269ea8 to e635693 Compare June 21, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants