Add focus border options (focus border on tabs, size, translucency)#595
Open
Tekisasu-JohnK wants to merge 1 commit into
Open
Add focus border options (focus border on tabs, size, translucency)#595Tekisasu-JohnK wants to merge 1 commit into
Tekisasu-JohnK wants to merge 1 commit into
Conversation
664cec6 to
2659fc6
Compare
jss2a98aj
requested changes
Dec 8, 2025
| @@ -621,8 +621,25 @@ void EditorThemeManager::_create_shared_styles(const Ref<EditorTheme> &p_theme, | |||
|
|
|||
| p_config.button_style_focus = p_config.button_style->duplicate(); | |||
| p_config.button_style_focus->set_draw_center(false); | |||
| p_config.button_style_focus->set_border_width_all(Math::round(2 * MAX(1, EDSCALE))); | |||
| p_config.button_style_focus->set_border_color(p_config.accent_color); | |||
| if ((int)EDITOR_GET("interface/editor/focus_border_type") == 0) { // Off | |||
Collaborator
There was a problem hiding this comment.
It would be cleaner to use a switch or at least only grab EDITOR_GET("interface/editor/focus_border_type") once here.
Author
There was a problem hiding this comment.
Switched to case syntax and reduced superfluous calls to EDITOR_GET(). Thanks @jss2a98aj
This adds two settings in Editor > Editor Settings > Interface > Editor (focus_border_on_tabs and focus_border_type). You can now disable focus borders on tabs entirely as well as minimize focus borders and alter their translucency, or turn them off entirely. update1: Clean up focus_border theming selection using cases per request from @jss2a98aj
2659fc6 to
b527751
Compare
jss2a98aj
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two settings in Editor > Editor Settings > Interface > Editor (focus_border_on_tabs and focus_border_type). You can now disable focus borders on tabs entirely as well as minimize focus borders and alter their translucency, or turn them off entirely.
Focus border on tabs toggle:
Screen.Recording.2025-12-07.034244.mp4
Changing focus border presentation:
Screen.Recording.2025-12-07.034441.mp4