Changed ext-salt packet iterations number restriction#182
Merged
Conversation
It used to be 3 because it was hardcoded so in the server, but it's gonna change to be configurable. The limit has been changed to 20 as it seen both enough for security reasons and prevens too long calculations on the client side. Most probably it will be also the limit in the server - not 3 for sure, but client does not really have to have the same limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the change I was talking in the comment about, the commit I've forgot to push
The limit used to be 3 because it was hardcoded so in the server and plugins for other language connectors had it as well, but it's gonna change to be configurable in the server. It is plain wrong anyway.
The limit has been changed to 20 as it seen both enough for security reasons and prevents too long calculations on the client side. Most probably it will be also the limit in the server - not 3 for sure, but client does not really have to have the same limit.