[PM-38613] Add timestamp for LastPasswordChangeDate#7768
Conversation
…UserAccountKeysAsync changes password
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES PR adds Code Review Details
Additional, low-impact: no unit test was added asserting the new |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7768 +/- ##
=======================================
Coverage 65.74% 65.74%
=======================================
Files 2219 2219
Lines 98064 98066 +2
Branches 8849 8849
=======================================
+ Hits 64471 64473 +2
Misses 31379 31379
Partials 2214 2214 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
|
||
| Assert.Equal(IdentityResult.Success, result); | ||
| Assert.NotNull(user.LastPasswordChangeDate); | ||
| Assert.InRange(user.LastPasswordChangeDate.Value, before, after); |
| Assert.NotNull(user.LastPasswordChangeDate); | ||
| Assert.InRange(user.LastPasswordChangeDate.Value, before, after); | ||
| Assert.NotNull(user.LastKeyRotationDate); | ||
| Assert.InRange(user.LastKeyRotationDate.Value, before, after); |
| Assert.Equal(IdentityResult.Success, result); | ||
| Assert.Equal(user.SecurityState, model.BaseData.AccountKeys.SecurityStateData!.SecurityState); | ||
| Assert.NotNull(user.LastPasswordChangeDate); | ||
| Assert.InRange(user.LastPasswordChangeDate.Value, before, after); |
| Assert.NotNull(user.LastPasswordChangeDate); | ||
| Assert.InRange(user.LastPasswordChangeDate.Value, before, after); | ||
| Assert.NotNull(user.LastKeyRotationDate); | ||
| Assert.InRange(user.LastKeyRotationDate.Value, before, after); |
3 participants
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38613
📔 Objective
When a user key and password change rotation happens we want to indicate a password change has happen by setting the LastPasswordChangeDate.