Skip to content

[deps] BRE: Update mysql Docker tag to v8.4#6763

Open
renovate[bot] wants to merge 3 commits into
mainfrom
renovate/docker-compose-minor
Open

[deps] BRE: Update mysql Docker tag to v8.4#6763
renovate[bot] wants to merge 3 commits into
mainfrom
renovate/docker-compose-minor

Conversation

@renovate

@renovate renovate Bot commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
mysql minor 8.08.4

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot requested review from a team as code owners December 22, 2025 03:30
@renovate renovate Bot requested a review from aj-bw December 22, 2025 03:30
@bitwarden-bot bitwarden-bot changed the title [deps] BRE: Update mysql Docker tag to v8.4 [PM-30028] [deps] BRE: Update mysql Docker tag to v8.4 Dec 22, 2025
@bitwarden-bot

Copy link
Copy Markdown
Collaborator

Internal tracking:

@codecov

codecov Bot commented Dec 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.45%. Comparing base (b3c8950) to head (aec0164).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6763   +/-   ##
=======================================
  Coverage   58.45%   58.45%           
=======================================
  Files        2067     2067           
  Lines       90997    90997           
  Branches     8083     8083           
=======================================
  Hits        53195    53195           
  Misses      35901    35901           
  Partials     1901     1901           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate Bot changed the title [PM-30028] [deps] BRE: Update mysql Docker tag to v8.4 [deps] BRE: Update mysql Docker tag to v8.4 Dec 22, 2025
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 2e00669 to 119038f Compare December 24, 2025 11:38
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.4 [deps] BRE: Update mysql Docker tag to v8.3 Dec 24, 2025
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 119038f to 4343333 Compare December 31, 2025 15:26
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.3 [deps] BRE: Update mysql Docker tag to v8.4 Dec 31, 2025
aj-bw
aj-bw previously approved these changes Jan 6, 2026

@aj-bw aj-bw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is just the dev resource, I assume this does not need full QA testing? cc @bitwarden/team-platform-dev

@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 4343333 to 10a70f6 Compare January 6, 2026 19:59
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.4 [deps] BRE: Update mysql Docker tag to v8.3 Jan 6, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 10a70f6 to 7b6b4f6 Compare January 13, 2026 19:06
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.3 [deps] BRE: Update mysql Docker tag to v8.4 Jan 13, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 7b6b4f6 to 637398f Compare January 17, 2026 02:07
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.4 [deps] BRE: Update mysql Docker tag to v8.3 Jan 17, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 637398f to c2e2934 Compare February 2, 2026 15:41
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch 2 times, most recently from 7b329a6 to 7d8ffce Compare February 13, 2026 01:15
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.3 [deps] BRE: Update mysql Docker tag to v8.4 Feb 13, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 7d8ffce to c55732b Compare February 20, 2026 02:56
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.4 [deps] BRE: Update mysql Docker tag to v8.3 Feb 20, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from c55732b to 5aee0d0 Compare February 26, 2026 23:08
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.3 [deps] BRE: Update mysql Docker tag to v8.4 Feb 26, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 5aee0d0 to 403511e Compare March 14, 2026 18:54
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.4 [deps] BRE: Update mysql Docker tag to v8.3 Mar 14, 2026
@renovate renovate Bot force-pushed the renovate/docker-compose-minor branch from 403511e to b74d344 Compare March 27, 2026 06:47
@renovate renovate Bot changed the title [deps] BRE: Update mysql Docker tag to v8.3 [deps] BRE: Update mysql Docker tag to v8.4 Mar 27, 2026
@rkac-bw

rkac-bw commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

since this is just the dev resource, I assume this does not need full QA testing? cc @bitwarden/team-platform-dev

This will be part of bitwarden lite which can support mariadb and possibly mysql so should be be sent to qa if approved

…N, add AllowPublicKeyRetrieval to connection string for MySQL 8.4 caching_sha2_password support
@renovate

renovate Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@rkac-bw rkac-bw requested a review from mimartin12 April 9, 2026 20:04
@rkac-bw

rkac-bw commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Tested locally: MySQL 8.4.8 works with Bitwarden. EF migrations, Identity, and API all pass against caching_sha2_password (default in 8.4).

Additional changes needed beyond the image tag bump:

  1. Remove --default-authentication-plugin=mysql_native_password from the mysql command in docker-compose.yml — this option is deprecated in 8.4 and removed in 9.0.
  2. Add --mysql-native-password=ON to the mysql command — this re-enables the plugin for users and developers with existing 8.0 data volumes, preventing auth failures on upgrade. Without this, existing
    databases break because users were created with mysql_native_password which is disabled by default in 8.4. The flag is deprecated but functional in 8.4, giving time to migrate.
  3. Update secrets.json.example MySQL connection string to include AllowPublicKeyRetrieval=true;SslMode=Preferred — required for caching_sha2_password authentication from the .NET connector.

Suggested docker-compose change:
mysql:
image: mysql:8.4
ports:
- "3306:3306"
command:
- --mysql-native-password=ON
- --innodb-print-all-deadlocks=ON

Post-upgrade action required: We should announce this change and advise users and developers that after upgrading to MySQL 8.4, they should convert their database users from mysql_native_password to caching_sha2_password to be fully secure:

ALTER USER 'root'@'%' IDENTIFIED WITH caching_sha2_password BY 'your_password';
ALTER USER 'root'@'localhost' IDENTIFIED WITH caching_sha2_password BY 'your_password';

Once all users are migrated, --mysql-native-password=ON can be removed from the compose file. This is important because mysql_native_password is less secure (weaker password hashing) and will be fully removed in MySQL 9.0.

Reference: https://bitwarden.atlassian.net/wiki/spaces/EN/pages/1860108507 (Confluence, Engineering space)

MariaDB is unaffected — separate container, separate connection string, separate auth mechanism. Tested side-by-side with MariaDB 12.2.2, no issues.

Do we want to push backup scripts like SQL server has before releasing this upgrade?

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details81a95b93-985e-4f57-9fbe-cd5bfd0e7959

Great job! No new security vulnerabilities introduced in this pull request

@rkac-bw

rkac-bw commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Tested MySQL 8.4 and MariaDB locally — both fully working with the connection string changes.

Note: MariaDB uses the same globalSettings.mySql.connectionString (via databaseProvider=mariadb mapping in ServiceCollectionExtensions.cs), so the added AllowPublicKeyRetrieval=true;SslMode=Preferred params
apply to both. These params are harmlessly ignored by MariaDB since it doesn't use caching_sha2_password.

@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

@withinfocus withinfocus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dev tooling change so there really isn't much risk, but you should make the upgrade path known internally given the auth differences -- might as well get ahead to prep for v9. What documentation needs to be updated outside of here?

For Maria and therefore Unified / lite users, you said we're already good with the stronger auth mechanism right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants