[deps] BRE: Update mysql Docker tag to v8.4#6763
Conversation
|
Internal tracking:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6763 +/- ##
=======================================
Coverage 58.45% 58.45%
=======================================
Files 2067 2067
Lines 90997 90997
Branches 8083 8083
=======================================
Hits 53195 53195
Misses 35901 35901
Partials 1901 1901 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2e00669 to
119038f
Compare
119038f to
4343333
Compare
aj-bw
left a comment
There was a problem hiding this comment.
since this is just the dev resource, I assume this does not need full QA testing? cc @bitwarden/team-platform-dev
4343333 to
10a70f6
Compare
10a70f6 to
7b6b4f6
Compare
7b6b4f6 to
637398f
Compare
637398f to
c2e2934
Compare
7b329a6 to
7d8ffce
Compare
7d8ffce to
c55732b
Compare
c55732b to
5aee0d0
Compare
5aee0d0 to
403511e
Compare
403511e to
b74d344
Compare
This will be part of bitwarden lite which can support mariadb and possibly mysql so should be be sent to qa if approved |
…N, add AllowPublicKeyRetrieval to connection string for MySQL 8.4 caching_sha2_password support
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
Tested locally: MySQL 8.4.8 works with Bitwarden. EF migrations, Identity, and API all pass against caching_sha2_password (default in 8.4). Additional changes needed beyond the image tag bump:
Suggested docker-compose change: Post-upgrade action required: We should announce this change and advise users and developers that after upgrading to MySQL 8.4, they should convert their database users from mysql_native_password to caching_sha2_password to be fully secure: ALTER USER 'root'@'%' IDENTIFIED WITH caching_sha2_password BY 'your_password'; Once all users are migrated, --mysql-native-password=ON can be removed from the compose file. This is important because mysql_native_password is less secure (weaker password hashing) and will be fully removed in MySQL 9.0. Reference: https://bitwarden.atlassian.net/wiki/spaces/EN/pages/1860108507 (Confluence, Engineering space) MariaDB is unaffected — separate container, separate connection string, separate auth mechanism. Tested side-by-side with MariaDB 12.2.2, no issues. Do we want to push backup scripts like SQL server has before releasing this upgrade? |
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Tested MySQL 8.4 and MariaDB locally — both fully working with the connection string changes. Note: MariaDB uses the same globalSettings.mySql.connectionString (via databaseProvider=mariadb mapping in ServiceCollectionExtensions.cs), so the added AllowPublicKeyRetrieval=true;SslMode=Preferred params |
|
withinfocus
left a comment
There was a problem hiding this comment.
This is a dev tooling change so there really isn't much risk, but you should make the upgrade path known internally given the auth differences -- might as well get ahead to prep for v9. What documentation needs to be updated outside of here?
For Maria and therefore Unified / lite users, you said we're already good with the stronger auth mechanism right?




This PR contains the following updates:
8.0→8.4Configuration
📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.