Skip to content

[PM-33948] Address workflow failure#6

Merged
jprusik merged 3 commits into
mainfrom
pm-33948-workflow-fix
Apr 10, 2026
Merged

[PM-33948] Address workflow failure#6
jprusik merged 3 commits into
mainfrom
pm-33948-workflow-fix

Conversation

@jprusik

@jprusik jprusik commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-33948

📔 Objective

Follow up from #4 to fix the release workflow

@jprusik jprusik self-assigned this Apr 10, 2026
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

Logo
Checkmarx One – Scan Summary & Details38c5c57f-7179-40ab-a8f7-6ab0f5978283

Great job! No new security vulnerabilities introduced in this pull request

@jprusik
jprusik requested a review from differsthecat April 10, 2026 13:30
@jprusik jprusik added the ai-review Request a Claude code review label Apr 10, 2026
@jprusik
jprusik marked this pull request as ready for review April 10, 2026 13:32
@jprusik
jprusik requested a review from a team as a code owner April 10, 2026 13:32
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR fixes the release workflow tag creation step by replacing git tag / git push with a gh api call to create the tag via the GitHub REST API. The previous approach failed because the checkout step uses persist-credentials: false, leaving git without push credentials. The new approach correctly authenticates via github.token. A minor documentation update removes a resolved limitation entry from the Forms Map README.

No findings.

@jprusik
jprusik merged commit 67cd1e9 into main Apr 10, 2026
9 of 11 checks passed
@jprusik
jprusik deleted the pm-33948-workflow-fix branch April 10, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants