Skip to content

Notifications: Fix - refresh the wallet on BWS pushes - #2533

Draft
gabrielbazan7 wants to merge 2 commits into
bitpay:developfrom
gabrielbazan7:fix/bws-push-wallet-refresh
Draft

gabrielbazan7 wants to merge 2 commits into
bitpay:developfrom
gabrielbazan7:fix/bws-push-wallet-refresh

Conversation

@gabrielbazan7

Copy link
Copy Markdown
Collaborator

After receiving funds, balances didn't update until the user pulled to refresh. This works together with bitpay/bitcore#.

  • On iOS, a notification that arrived while the app was open never reached the app logic, so it didn't trigger a refresh. Now it does.
  • Notifications for token transfers never found their wallet, so they didn't refresh anything. Now they refresh the right token wallet.
  • If two notifications arrived within a few seconds of each other, the second one was ignored, even for a different wallet. Now each wallet refreshes on its own, and a quick second notification is not lost.
  • The app now handles the new silent notification BWS sends when an incoming transaction is confirmed, which is when the EVM balance actually changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant