Repository navigation
Conversation
cmgustavo
force-pushed
the
bug/screen-bottom-blank-space-01
branch
from
November 17, 2026 20:15
e4c2411 to
50ebc54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a blank strip at the bottom of iOS screens that clipped scrollable content above the home indicator (most visible when scrolling to the end of a list).
Cause
Screens use the
SafeAreaViewfromreact-nativecore, which on iOS pads all four edges, including the bottom one. Scroll views inside it stop ~34pt before the screen edge. The most likely trigger is the React Native 0.87 /react-native-screens4.27 /react-native-safe-area-context5.8 upgrade, but this was not bisected.Changes
src/components/safe-area/SafeAreaView.tsx, a drop-in replacement for the coreSafeAreaView. On iOS it uses thereact-native-safe-area-contextone withedges={['top', 'left', 'right']}by default (no bottom padding). Android keeps the core component, so its behavior is unchanged.react-native-safe-area-contextSafeAreaViewapplies the insets of its nearest native provider (the app root), not the insets at its own position, so under a stack header it added the status bar height a second time. The wrapper renders aSafeAreaListener(a native provider with no JS state) right around it, so the insets are measured where the view is: 0 at the top under a header, like the core component.useSafeAreaInsets()still returns the window insets to the children. Layout style keys (flex, size, margins, position) go on the outer view so the extra view does not change the screen layout.edgesprop and an exportedALL_EDGESconstant to the wrapper. Screens with a fixed bottom CTA that is not insideCtaContainerAbsolute/FooterButtonContainerpassedges={ALL_EDGES}so the CTA stays above the home indicator, as before: sendConfirm,PayProConfirm,WalletConnectConfirm,TransactionProposalDetails,SwapCryptoRoot,SwapCryptoApproveErc20, the Moonpay/Ramp/Simplex sell checkouts,MoonpayBuyEmbeddedOnboarding,Copayers,CreateMultisig,CurrencySelection,SelectInputs,InviteCosignersandJoinTSSWallet. These were found with an AST scan of every wrapper usage whose last non-modal child is a non-scroll view with a button.react-nativeSafeAreaViewimport with the new component in 107 files, includingScreenContainer,KeyOverviewandSettingsContainer. Two modals that import it under an alias (OfferSelectorModal,SwapCryptoOfferSelectorModal) are intentionally left untouched.KeyOverview: reduce the wallet list footerpaddingBottomfrom 100 to 20.The bottom tab bar is not modified.
Testing
BalanceDetailsModal(bottom sheet): no extra top padding, last section readable above the home indicator.tscreports no new errors insrc/,eslintreports no errors in the changed files.AmountModal,BottomAmountModal,ChangellyPoliciesModal,CloudflareChallenge, and the other screens that now useALL_EDGES.Jira: RN-3122