Repository navigation
Performance: Testing - time Buy/Sell/Swap coin lists and quotes with spans - #2476
Open
JohnathanWhite wants to merge 2 commits into
Open
JohnathanWhite wants to merge 2 commits into
JohnathanWhite wants to merge 2 commits into
Conversation
Adds the trade-flow half of the performance harness on top of the perf framework from bitpay#2475: Maestro scenarios that drive Buy, Sell and Swap read-only (quotes load, nothing is confirmed, signed or submitted), per-scenario accepted runs and per-screen transition comparisons, a JS-CPU flow profiler, the process-memory mode recorded per run, and the trade findings. - perf/scenarios/trade_{buy,sell,swap}.yaml - the three flows. - perf/loop/flowprofile.sh - JS CPU profile of a flow. - perf/loop/FINDINGS-trade.md - root causes, baselines, parked items. - perf/{cli,collector,config,compare,drivers/android,iterate} - per-scenario runs, coin-list and quote spans, memory-mode recording. - src/perf/PerfMonitor.ts - spanStart/spanEnd for sub-screen timing. - Android PerfMarks/MainApplication - non-perf builds compile against the new startJsProfiler(context); perf marks for the profiler. Jira: RN-3106
…spans Wire the PerfMonitor span API into the trade screens so the perf harness can report how long each flow takes to become usable, as pseudo-screens in the per-screen transitions: - BuyCurrencies / SellCurrencies / SwapCurrencies: init start until the supported-coin list is set. - BuyQuotes / SellQuotes / SwapQuotes: quote round requested (including the debounce) until the best offer is selected, or until every provider has answered with no usable offer. spanStart/spanEnd return immediately unless the build has IS_PERF=true, so release builds are unaffected. No change to what the screens do. These are the spans the trade scenarios and FINDINGS-trade.md numbers were measured with; they were left out when the product changes (bitpay#2506) and the harness (bitpay#2507) were split out of bitpay#2476.
JohnathanWhite
force-pushed
the
perf/buy-sell-swap
branch
from
November 17, 2026 19:30
1937172 to
dbca88a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2507. Its commit appears here until it lands; this PR is the one commit after it (4 files, +18).
Summary
This PR originally carried the whole Buy/Sell/Swap perf effort, stacked on #2475. Since then #2475 merged, the product-code half merged as #2506, and the harness half is #2507. What is left is the instrumentation both omitted: the
spanStart/spanEndcalls that the trade scenarios andperf/loop/FINDINGS-trade.mdin #2507 rely on. Without them nothing emits the six spans those scenarios report.The branch was rebuilt on current
develop; the previous head is 1937172.Changes
BuyCurrencies/SellCurrencies/SwapCurrencies: init start until the supported-coin list is set.BuyQuotes/SellQuotes/SwapQuotes: quote round requested (including the debounce) until the best offer is selected, or every provider has answered with no usable offer.Spans are no-ops unless the build has
IS_PERF=true. No behaviour change.Known gaps
PerfMonitor.tshas no unit tests.Testing
yarn validatepasses)src/navigation/servicesandsrc/perf: 13 tests pass (none exercises the spans)trade_buy/trade_sell/trade_swapshowing the six spansJira: RN-3106