Define Backend POC room lifecycle and errors#64
Open
VoldemLive wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
The Backend POC documentation defined event payloads but did not fully specify lifecycle transitions, error precedence, or event-specific error conditions. This change makes room behavior deterministic for implementation and integration tests, synchronizes the related plans, and removes the obsolete
credentialTypefield from the documentedIceServershape.Related Issue
Closes #2
Updates
Before
IceServerincluded obsolete OAuth-related fields.After
IceServernow matches the current browser contract used by the project.Acceptance Criteria
Testing Steps / QA Criteria
git diff --check main...HEAD— passed.node --check server/src/index.js— passed.