[WIP] feat: add common subnode aggregation#46
Draft
jspaezp wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[copying here the text from https://github.com//issues/47]
Hello!
First of all thanks a lot for the crate, it has been incredibly handy.
I was wondering if you would be interested in a feature that I am experimenting with and found useful.
The main issue is that for calls that are executed in loops, I generally require knowing how much the aggregate time was instead of the per-call timing, so aggregating equivalent sub-graphs greatly simplifies this process.
Example (That I should have made more minimal ... but shows the point):
Right now outputs the very verbose:
But if we aggregate all equivalent sub-graphs, we get the more concise:
LMK if you would be interested in the PR, I can polish my branch and make it a thing. (https://github.com/jspaezp/tracing-profile/tree/feat/aggregate_common right now ... there are a couple of TODOs I would like to handle before it "goes into the wild" but has worked well for a couple of my projects)
Best!