Skip to content

Removed unused code in locally free access#29

Draft
tgrospic wants to merge 2 commits into
bigsur-network:devfrom
tgrospic:normalizer-matcher-cleanup
Draft

Removed unused code in locally free access#29
tgrospic wants to merge 2 commits into
bigsur-network:devfrom
tgrospic:normalizer-matcher-cleanup

Conversation

@tgrospic
Copy link
Copy Markdown

@tgrospic tgrospic commented Jun 13, 2023

Overview

Removed unused code in normalizer.

Please make sure that this PR:

Bors cheat-sheet:

  • bors r+ runs integration tests and merges the PR (if it's approved),
  • bors try runs integration tests for the PR,
  • bors delegate+ enables non-maintainer PR authors to run the above.

@tgrospic tgrospic marked this pull request as ready for review June 14, 2023 16:45
@tgrospic tgrospic requested review from hilltracer and nzpr June 14, 2023 16:45
hilltracer
hilltracer previously approved these changes Jun 15, 2023
Copy link
Copy Markdown

@hilltracer hilltracer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

case ESetBody(e) => e.locallyFree.value
case EMapBody(e) => e.locallyFree.value
case EVarBody(EVar(v)) => VarLocallyFree.locallyFree(v, depth)
case EVarBody(EVar(v)) => VarInstanceLocallyFree.locallyFree(v.varInstance, depth)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove all depth from this file, e.g. here or from prepend methods. But this will require a lot of changes in the Reducer, so I can do it while working on new types.

@tgrospic tgrospic force-pushed the normalizer-matcher-cleanup branch from 5fa9590 to 68bf7d3 Compare June 17, 2023 08:28
@tgrospic tgrospic marked this pull request as draft July 17, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants