fix: only deploy newest build per app in scanExistingJobs#103
Open
tdussmann wants to merge 1 commit into
Open
Conversation
…rollback loops When the build watch restarts (every ~40-60min on K8s watch expiry), scanExistingJobs processed every SUCCEEDED build job in alphabetical order, triggering a deployment for each. With multiple builds per app, the alphabetically-last (often older) job would overwrite the deployment, causing unnecessary pod restarts and rollbacks. Now jobs are grouped by appId, sorted by creationTimestamp descending, and only the newest successful job triggers a deployment per app. Fixes biersoeckli#100 Co-authored-by: HermesAgent <hermes@nousresearch.com>
tdussmann
force-pushed
the
fix/scan-existing-jobs-deploy-only-newest-build
branch
from
2fe902b to
6de7612
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...prevents rollback loops
When the build watch restarts (every ~40-60min on K8s watch expiry), scanExistingJobs processed every SUCCEEDED build job in alphabetical order, triggering a deployment for each. With multiple builds per app, the alphabetically-last (often older) job would overwrite the deployment, causing unnecessary pod restarts and rollbacks.
Now jobs are grouped by appId, sorted by creationTimestamp descending, and only the newest successful job triggers a deployment per app.
Fixes #100