Allow using locks while TLS is destructed#61
Merged
Conversation
qsr
force-pushed
the
tls_safe
branch
2 times, most recently
from
30447db to
02578e6
Compare
|
Note that this changes the behavior of locking so that when we don't know what locks this thread holds (i.e. during thread teardown), we allow locking to proceed. The old behavior is to panic in that situation. |
bertptrs
requested changes
Jun 17, 2026
bertptrs
left a comment
bertptrs
left a comment
Owner
There was a problem hiding this comment.
Thank you for your PR. The testcase clearly demonstrates what goes wrong.
As @djkoloski mentions, this does technically change behaviour, but the current behaviour results in an unhelpful
fatal runtime error: thread local panicked on drop, aborting
which isn't informative. Since regular dependency tracking cannot continue at this point, I believe letting it slide is the way forward.
Could you address my review comment and run cargo fmt on your code? Other than that LGTM.
bertptrs
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.