subscribe to all direct message channels in conversation#124
Merged
Conversation
support the addition of future agent DMs by subscribing to all direct channels, filtering intro msg to just eventAssistant
only emit join event when socket has fully connected to avoid duplicate send mid-handshake
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
when useEffects run twice, has potential to create duplicate direct channels
johnnycrich
approved these changes
Jun 5, 2026
| } | ||
|
|
||
| const joinConversation = () => { | ||
| if (hasJoinedConvRef.current) return; |
Collaborator
There was a problem hiding this comment.
Great solution for dedupe here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
We are adding another agent to send private checkins to users. Rather than hard-coding the websocket subscription to this agent's direct channel (and jargonFilter's direct channel), this PR modifies assistant to subscribe to all direct channels in the conversation. Also contains a timing fix on emitting the conversation:join to avoid creation of duplicate direct channels
Changes in the codebase
See above
Documentation and automated testing
Did you:
content/whatsNew.tsfor new features?Testing this PR
Additional information