Implement mirror check by johnnycrich · Pull Request #482 · berkmancenter/frankly

johnnycrich · 2026-06-11T19:13:46Z

What is in this PR?

Introduces a basic "mirror check" feature to ensure users verify their camera and microphone settings before joining a meeting. The changes also enhance error handling and user feedback during device setup.

Changes in the codebase

Integrated the mirror check status into MediaDeviceService for runtime access. (media_device_service.dart)
Updated MediaSettingsWidget to support a mirror check mode, including a new introductory message, modified save button behavior, and logic to mark the mirror check as complete. (media_settings_widget.dart)
Improved device selection and preview logic, and clarified the distinction between device selection and streaming state in the UI. (media_settings_widget.dart)
Improves the distinction between device readiness and actual audio/video streaming. Added explicit flags (audioIsStreaming, videoIsStreaming) to track whether audio/video is actually being sent, separate from device enablement. Updated all relevant logic and toggles to use these flags. (agora_room.dart, conference_room.dart).
Modified audio/video enablement logic to only allow streaming if the mirror check has been completed, preventing premature streaming. (conference_room.dart)
Added a local storage flag (array) in SharedPreferencesService to track if the user has completed the mirror check per event.
Improved error handling and logging throughout device setup and streaming toggles to assist with debugging and ensure user state is reset correctly on failure. (media_settings_widget.dart, conference_room.dart)
Only show the grid of participants if mirror check is complete. (video_flutter_meeting.dart)

Testing this PR

Create a new event and enter it. For now, use hosted.
initially, you should not see any other participants in the meeting, whether or not they have a A/V enabled.
You should see a pop-up stating "Audiovisual Settings", with dropdowns for both camera and audio devices. When video device changes, the preview should reflect that.
Click save and close.
Note that any other participants now appear, and your mic and camera are still off.
Verify that after turning them on your camera and microphone use your desired devices.
Access the AV settings panel as normal and verify that changing devices still works as intended.
Refresh the event and note that you do not see the mirror check again, and that your devices now turn on by default.
Try the above steps again with both a hostless and livestream event. You should not see the mirror check in those events before you enter a breakout room.

PR Checklist

Where applicable, I have added localization (l10n) entries to my feature for user-facing text.
For new Cloud Functions, I have added the function to function-mapping.json.

AI tools used (if applicable):
Copilot assisted in drafting this PR.

…e original branch had incorrect parent.

github-actions · 2026-06-11T19:21:13Z

Visit the preview URL for this PR (updated for commit 2afeff8):

https://gen-hls-bkc-7627--pr482-jr-feat-mirror-check-hfijea56.web.app

_{(expires Fri, 26 Jun 2026 16:06:51 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: eed668cca81618d491d024574a8f8a6003deaa8d}

…ck using media_device_svc.

Copilot

Pull request overview

Implements a per-event “mirror check” flow that forces users to review/select camera & microphone devices before they can stream A/V or see other participants in a meeting. This is integrated into meeting connection, UI controls, participant rendering, and persisted locally so the mirror check is only shown once per event.

Changes:

Added mirror-check completion persistence via SharedPreferencesService and used it to gate A/V streaming and participant visibility.
Updated meeting UI to distinguish “device enabled” vs “actually streaming” and updated toggles/participant rendering accordingly.
Refreshed the media settings dialog UI/copy and device-save logic, including new l10n keys.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
client/lib/l10n/app_en.arb	Adds mirror-check related strings; currently introduces a duplicate key issue (`and`).
client/lib/l10n/app_es.arb	Adds mirror-check related strings; currently introduces a duplicate key issue (`and`).
client/lib/l10n/app_zh.arb	Adds mirror-check related strings; currently introduces a duplicate key issue (`and`).
client/lib/l10n/app_zh_Hant_TW.arb	Adds mirror-check related strings (Traditional Chinese).
client/lib/core/widgets/media_settings_widget.dart	Updates A/V settings dialog UI and save behavior for mirror-check mode; contains a critical rollback bug and dead state.
client/lib/core/utils/media_device_service.dart	Minor formatting-only change.
client/lib/core/data/services/shared_preferences_service.dart	Adds per-event mirror-check completion tracking APIs.
client/lib/features/events/features/live_meeting/features/video/data/providers/agora_room.dart	Introduces separate “is streaming” flags for local participant A/V state.
client/lib/features/events/features/live_meeting/features/video/data/providers/conference_room.dart	Gates A/V streaming on mirror-check completion; shows mirror-check dialog on connect; introduces unused imports and state-semantic mismatch.
client/lib/features/events/features/live_meeting/features/video/presentation/widgets/control_bar.dart	Updates controls to use streaming flags and (partially) gate toggles based on mirror-check completion; video toggle gating and messaging need fixes.
client/lib/features/events/features/live_meeting/features/video/presentation/widgets/participant_widget.dart	Uses streaming flags for local audio state and hides video view until mirror check is complete.
client/lib/features/events/features/live_meeting/features/video/presentation/views/video_flutter_meeting.dart	Hides participant grid until mirror check is complete (but only for one layout branch).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

johnnycrich · 2026-06-12T15:59:07Z

              child: Container(
                padding: const EdgeInsets.all(8),
                alignment: Alignment.center,
-                child: ParticipantGridLayout(),
+                // Only show the grid if mirror check is complete for this event
+                child: sharedPreferencesService.hasMirrorCheckCompletedForEvent(widget.liveMeetingProvider.eventProvider.eventId)
+                    ? ParticipantGridLayout()
+                    : const SizedBox.shrink(),


defaultStageView is currently not exposed as an option to be changed, so the grid view is always Brady Bunch.

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

client/lib/features/events/features/live_meeting/features/video/data/providers/conference_room.dart:382

On camera permission denial, the code sets videoTrackEnabled = false but leaves videoIsStreaming unchanged and does not update shouldStartLocalVideoOn. Since the UI now uses videoIsStreaming (and the provider uses shouldStartLocalVideoOn) for state, this can leave the UI/provider out of sync after a failed enable attempt.

    if (updatedEnabledValue) {
      final permissionStatus = await Permission.camera.request();
      if (permissionStatus.isDenied || permissionStatus.isPermanentlyDenied) {
        if (!context.mounted) return;
        await showAlert(
          context,
          'Error enabling camera. Please ensure you have granted permission.',
        );
        _room?.localParticipant?.videoTrackEnabled = false;
        return;

+        try {
+          if (sharedPreferencesService.hasMirrorCheckCompletedForEvent(liveMeetingProvider.eventProvider.eventId)) {
+            await _room!.localParticipant!.enableVideo(
+              setEnabled: updatedEnabledValue,
+            );
+          }
+          if (updateProvider) {
+            liveMeetingProvider.shouldStartLocalVideoOn = updatedEnabledValue;
+          }
+        } catch (e) {
+          loggingService.log('Error toggling video: $e');
        }


+        try {
+          final audioEnableFutures = [
+            if (sharedPreferencesService.hasMirrorCheckCompletedForEvent(liveMeetingProvider.eventProvider.eventId))
+              _room!.localParticipant!.enableAudio(
+                setEnabled: updatedEnabledValue,
+              ),
+            if ((liveMeetingProvider
+                        .eventProvider.selfParticipant?.muteOverride ??
+                    false) &&
+                updatedEnabledValue)
+              firestoreLiveMeetingService.updateParticipantMuteOverride(
+                event: liveMeetingProvider.eventProvider.event,
+                participantId: userService.currentUserId!,
+                muteOverride: false,
+              ),
+          ];
+
+          await Future.wait(audioEnableFutures);
+
+          if (updateProvider) {
+            liveMeetingProvider.shouldStartLocalAudioOn = updatedEnabledValue;
+          }
+        } catch (e) {
+          loggingService.log('Error toggling audio: $e');
        }


+        _room?.localParticipant?.audioIsStreaming = false;
        return;


+                      setState(() {
+                        isLoadingCameraChange = false;
+                      });


+          return MediaSettingsWidget(
+            conferenceRoom: this,
+            shouldShowVideoPreview: liveMeetingProvider.videoDefaultOn,
+            isMirrorCheck: true,
+          );


+        return videoEnabled
+            ? AgoraVideoView(
+                controller: videoViewController!,
+              )
+            : SizedBox.shrink();


johnnycrich added 2 commits June 11, 2026 15:11

chore(client): cherry-pick from origin/11-implement-mirror-check sinc…

5c4ca83

…e original branch had incorrect parent.

chore(client): cherry-pick from origin/11-implement-mirror-check sinc…

d3cb806

…e original branch had incorrect parent.

johnnycrich temporarily deployed to staging June 11, 2026 19:13 — with GitHub Actions Inactive

chore(client): cleanup.

11479dc

johnnycrich temporarily deployed to staging June 11, 2026 19:43 — with GitHub Actions Inactive

johnnycrich changed the title ~~Jr/feat/mirror check~~ Implement mirror check Jun 11, 2026

feat(client): mirror check preference now array of IDs, disuse of che…

7e94451

…ck using media_device_svc.

johnnycrich temporarily deployed to staging June 12, 2026 13:33 — with GitHub Actions Inactive

johnnycrich linked an issue Jun 12, 2026 that may be closed by this pull request

Implement Mirror Check #11

Open

refactor(client): update l10n strings.

d840ad1

johnnycrich temporarily deployed to staging June 12, 2026 14:05 — with GitHub Actions Inactive

johnnycrich requested a review from katherineqian June 12, 2026 14:13

johnnycrich added the enhancement New feature or request label Jun 12, 2026

johnnycrich marked this pull request as ready for review June 12, 2026 14:14

Copilot AI review requested due to automatic review settings June 12, 2026 14:14

Copilot started reviewing on behalf of johnnycrich June 12, 2026 14:14 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

fix(client): misc fixes as per review.

2afeff8

johnnycrich temporarily deployed to staging June 12, 2026 16:00 — with GitHub Actions Inactive

johnnycrich requested a review from Copilot June 12, 2026 16:01

Copilot started reviewing on behalf of johnnycrich June 12, 2026 16:02 View session

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement mirror check#482

Implement mirror check#482
johnnycrich wants to merge 6 commits into
stagingfrom
jr/feat/mirror-check

johnnycrich commented Jun 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnnycrich Jun 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

johnnycrich commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is in this PR?

Changes in the codebase

Testing this PR

PR Checklist

Uh oh!

github-actions Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnnycrich Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

johnnycrich commented Jun 11, 2026 •

edited

Loading

github-actions Bot commented Jun 11, 2026 •

edited

Loading