refactor: replace spawn('which') with 'which' npm package#75
Closed
marcusolsson wants to merge 1 commit into
Closed
refactor: replace spawn('which') with 'which' npm package#75marcusolsson wants to merge 1 commit into
marcusolsson wants to merge 1 commit into
Conversation
Replace the manual spawn('which', [binary]) approach in SpawnCommandRunner
checkInstalled() with the cross-platform 'which' package.
Benefits:
- Cross-platform: works on Windows (where.exe) and Unix (which)
- No child process overhead for simple PATH lookups
- Cleaner error handling (try/catch vs exit code checking)
Contributor
Author
|
Merged manually via fast-forward. The changes from this PR (plus a compatibility fix downgrading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the manual
spawn('which', [binary])approach inSpawnCommandRunner.checkInstalled()with the cross-platformwhichnpm package.Changes
src/commands/code/adapters/spawn-command-runner.ts: Replaced child-process-basedwhichcheck with thewhichlibrarypackage.json: Addedwhichas a dependency and@types/whichas a dev dependencyBenefits
where.exe) and Unix (which) without manual platform detectiontry/catchinstead of exit code checkingVerification
tsc --noEmit)vitest run)