Skip to content

fix: Event being polyfilled when not needed #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThaUnknown wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Event being polyfilled when not needed #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5152219
fix: Event being polyfilled when not needed
ThaUnknown Mar 17, 2023
8becf1f
fix: webos
ThaUnknown Mar 17, 2023
5cb9a0e
fix: redeclare
ThaUnknown Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@ const root =

function isConstructor(fn) {
try {
new fn();
new fn('');
} catch (error) {
return false;
}
return true;
}
const hasEvent = isConstructor(root.Event)
const hasTarget = isConstructor(root.EventTarget)

if (typeof root.Event !== "function" || !isConstructor(root.Event)) {
if (!hasEvent) {
root.Event = (function () {
function Event(type, options) {
this.bubbles = !!options && !!options.bubbles;
Expand All @@ -25,7 +27,8 @@ if (typeof root.Event !== "function" || !isConstructor(root.Event)) {
})();
}

if (typeof root.EventTarget === "undefined" || !isConstructor(root.Event)) {

if (!hasEvent || !hasTarget) {
root.EventTarget = (function () {
function EventTarget() {
this.__listeners = new Map();
Expand Down Expand Up @@ -76,7 +79,7 @@ if (typeof root.EventTarget === "undefined" || !isConstructor(root.Event)) {
};

EventTarget.prototype.dispatchEvent = function (event) {
if (!(event instanceof Event)) {
if (!(event instanceof root.Event)) {
throw new TypeError(
`Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.`
);
Expand Down