Add --class-name param to prepend class names to methods#654
Open
karolinepauls wants to merge 1 commit into
Open
Add --class-name param to prepend class names to methods#654karolinepauls wants to merge 1 commit into
--class-name param to prepend class names to methods#654karolinepauls wants to merge 1 commit into
Conversation
karolinepauls
force-pushed
the
include-class-name
branch
2 times, most recently
from
af526d3 to
4994379
Compare
Regular methods and classmethods supported. No support for static methods. This is because the frame object doesn't refer to the function, only its code, which leaves no other option than to try to find `self` or `cls` in locals. The alternative of using the `gc` module is horrendously slow even in the same process and also impractical in a remote process.
karolinepauls
force-pushed
the
include-class-name
branch
from
1ac017a to
4d64d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regular methods and classmethods supported. No support for static methods. This is because the frame object doesn't refer to the function, only its code, which leaves no other option than to try to find
selforclsin locals. The alternative of using thegcmodule is horrendously slow even in the same process and also impractical in a remote process.I was experiencing unaligned memory reads in
coredump::test::test_coredumplocally, unrelated to my changes. I fixed it in a separate PR.it works in the record mode:
