Repository navigation
docs: security assessment — public-internet readiness review - #279
Merged
Merged
Conversation
Full code-level review of all attack surfaces (Subsonic, admin, SPA, proxy, DLNA, Sonos, federation, external fetches, deps) assessed against OWASP Top 10, CIS Docker Benchmark, and credential-handling guidance. Verdict: not public-internet-ready as-is; 5 high findings (no TLS/Secure cookies, permissive CORS, proxy path leak, 43 dep advisories, no rate limiting) plus hardening checklists. closes #278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds root-level SECURITY.md: full code-level review of every attack surface assessed against OWASP Top 10 (2021), CIS Docker Benchmark, and credential-handling guidance, with a public-internet readiness verdict and split code/operator hardening checklists.
Verdict: not public-internet-ready as-is. Five high findings — no TLS/Secure-cookies/HSTS, CORS reflects any origin with credentials, the Navidrome proxy forwards arbitrary paths (leaks admin JWT minting and the native API), 43 dependency advisories (22 high), no rate limiting anywhere — plus ten medium/low. No injection-class issues found (SQL/XSS/XXE all clean); federation crypto and cast tokens verified solid.
Docs-only change. Closes #278 on merge.