Skip to content

Fix Gopher quality filter test assertion#3

Draft
vsabolcec wants to merge 9 commits into
mainfrom
tests
Draft

Fix Gopher quality filter test assertion#3
vsabolcec wants to merge 9 commits into
mainfrom
tests

Conversation

@vsabolcec

@vsabolcec vsabolcec commented Mar 4, 2024

Copy link
Copy Markdown
Collaborator

This pull request introduces changes to the test_gopher_quality() function to fix the assertion statement. The original test used
self.assertTrue(gopher_quality(get_doc(TEXT_LF_1))), which would always get resolved as True because gopher_quality(...) returns a Generator.

To fix this issue, the test has been updated to use the filter() method of the gopher_quality object.

vsabolcec and others added 9 commits March 1, 2024 16:21
* add command file and project setting

* fix style

* display precentage and remove unused regex

* show complete as well by default

* small improvements

---------

Co-authored-by: guipenedo <nostrumg@gmail.com>
@vsabolcec vsabolcec changed the title [WIP] Fix test assert Fix Gopher quality test assertion Mar 7, 2024
@vsabolcec vsabolcec changed the title Fix Gopher quality test assertion Fix Gopher quality filter test assertion Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants