Skip to content

Refuse a redirect to a different page when fetching a source; allow generic type syntax in card text - #20

Merged
belyaev-dev merged 1 commit into
mainfrom
fetch-redirect-and-generics
Nov 19, 2026
Merged

belyaev-dev merged 1 commit into
mainfrom
fetch-redirect-and-generics

Conversation

@belyaev-dev

Copy link
Copy Markdown
Owner

Two gaps a feed ran into.

  • A retired article redirected to a marketing page that answered 200 with plenty of prose, and fetch-source.mjs saved it as the source. Both fetchers now stop (exit 4) when the final address no longer contains the article's own path name.
  • The no-markup pattern rejected Rust and TypeScript generics such as Vec<u8> as HTML tags. An angle bracket that follows a word character is now allowed; <b>, </div> and comments after a space are still rejected.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0839f6b5-1c95-4d07-b8f8-f53dd6dd8251
Commits

Reviewing files that changed from the base of the PR and between bb26b32 and f144f22.

Files selected for processing: 4

  • CONTRIBUTING.md
  • schema/card.schema.json
  • scripts/fetch-browser.py
  • scripts/fetch-source.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@belyaev-dev
belyaev-dev merged commit 7dfab78 into main Nov 19, 2026
5 checks passed
@belyaev-dev
belyaev-dev deleted the fetch-redirect-and-generics branch November 19, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant