GitHub actions#323
Open
seanwayland wants to merge 21 commits into
Open
Conversation
- issue belangeo#300 in upstream repo.
Add context manager support to the Server object
…paths - Windows: Injects VCPKG_ROOT environment variable with corrected path - macOS: Ensures BREW_OPT_ROOT uses system default paths - Linux: No patch needed, system paths work correctly - Modifications only affect CI runners, not committed to master
- Windows: Use PowerShell string operations instead of bash heredoc - Cross-platform: Use python shell instead of bash heredoc
- Windows paths with backslashes were being interpreted as escape sequences - Now properly escape backslashes in regex replacement string
- Use raw strings (r'...') to prevent backslash interpretation - Replace Unicode checkmark with ASCII [OK] for CP1252 compatibility
- Set CFLAGS, LDFLAGS, C_INCLUDE_PATH, LIBRARY_PATH for Linux - Ensure system include paths are available to compiler - Linux didn't have a patch before, now uses environment variables
- Double escape backslashes before using in re.sub() replacement - PowerShell already handles this correctly, just simplified
- Windows: Use function-based regex replacement to avoid escape interpretation - Linux: Patch setup.py to add /usr/include and /usr/local/include to include_dirs - PowerShell: Use regex::Escape for safer pattern matching
- libportaudio2 is runtime library only - libportaudio-dev provides headers needed for compilation (portaudio.h) - This should fix the 'fatal error: portaudio.h: No such file or directory' on Linux
- portaudio19-dev (correct) instead of libportaudio-dev (doesn't exist) - libjack-jackd2-dev instead of build-essential - libsndfile-dev instead of libsndfile1-dev - Follow official documentation from docs/compiling.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I worked on this with copilt.
The idea is for github CI/CD to run the tests on windows.