test(e2e): de-flake journey phases 1+2 under full-suite parallel load#78
Conversation
Running the journey spec inside the FULL parallel suite surfaced a flake the standalone runs never hit: a Next.js <Link> RSC prefetch races navigation under load and logs 'Failed to fetch RSC payload … Falling back to browser navigation' — the router falls back fine, nothing user-visible breaks. Phase 4 already filtered this; phases 1 and 2 did not. Extract the shared isBenignConsoleError() helper (auth/me probe noise + RSC prefetch fallback) and apply it in all three console-asserting phases. Verified: 97/97 across the whole e2e suite, twice.
|
Warning Review limit reached
More reviews will be available in 11 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Round 12 added tests/e2e/user-journey.spec.ts (PRs #76-#78) — the fifth testing lens: one spec walking production end-to-end through the rendered UI. This commit records it everywhere the project documents its testing posture, approach, and known issues: - README / README-TH: e2e count 93 → 97 (6 spec files), four-lens → five-lens posture, Round 12 summary line, quality-gate table. - CHANGELOG: full Round 12 entry — phase table, what building the spec itself surfaced (intermittent register error-boundary crash, silent sub-500-byte file rejection, duplicate-label button trap, benign console-noise classes), side-effect budget, test posture. - RELEASE_NOTES: Round 12 section at top (unreleased). - CONTRIBUTING: journey-spec section in Testing with run command, per-run cost, and the four extension rules. - docs/GUIDELINE: "The full user-journey lens" — the approach (terminal- state assertions, runtime fixtures above client floors, type=submit over text selectors, documented-pattern console filtering) and method (phase independence, crash sentinels, side-effect budgets, when to run). Coverage table updated to 171 unit / 97 e2e. - docs/ITERATION_PROCESS: §3 notes the spec automates manual checks 1/3/4/5; §9 four-lens → five-lens table with the Round 12 row and the integration-seam lesson. - docs/KNOWLEDGE_BASE: user-journey row in the Playwright table + a Round 12 section with the seven design decisions for extending it. - docs/KNOWN_ISSUES: new §2a (intermittent client error boundary on register response — sentinel-pinned, medium priority) and §5 (known-benign console-error noise, documented so new specs reuse the shared filter instead of rediscovering "flakes"). - docs/claude.md + docs/gemini.md: AI-guide sections pointing at the spec, its traps, and the GUIDELINE recipe.
2 participants
Follow-up to #76. Running the journey spec inside the full parallel e2e suite surfaced a flake the standalone runs never hit: a Next.js
<Link>RSC prefetch races navigation under load and logsFailed to fetch RSC payload … Falling back to browser navigation— the router falls back successfully, nothing user-visible breaks. Phase 4 already filtered this pattern; phases 1 and 2 did not.Extracts a shared
isBenignConsoleError()helper (auth/me probe noise + RSC prefetch fallback) and applies it in all three console-asserting phases.Verification: full e2e suite (all 6 specs, 97 tests) run twice against production — 97/97 both times (~1.1 min per run). One earlier run also confirmed the deep-probes conditional 429 test passes when Cloudflare routing cooperates.
https://claude.ai/code/session_01BWLU1nKZpxToH5hMeBDusG
Generated by Claude Code