Skip to content

A bunch of Improvements / Refactoring#2

Open
CyborgMaster wants to merge 34 commits into
beantowel:masterfrom
CyborgMaster:keymouse
Open

A bunch of Improvements / Refactoring#2
CyborgMaster wants to merge 34 commits into
beantowel:masterfrom
CyborgMaster:keymouse

Conversation

@CyborgMaster

Copy link
Copy Markdown

I had need of a tool like this and built on what you started. I've extended what you had with a couple features:

  • Interacting with stdin and stout instead of hardcoded file paths
  • HID Usage Pages in their own files instead of one big file
  • Outputting Usages in hex instead of decimal numbers to better match the docs
  • Updating the enum names to match the ones from the official docs and official HID windows descriptor tool
  • Printing the length in hex both normal order and byte reversed for easier inclusion in USB little endian communication.

And probably some other stuff.

It is a big rework of what you've done, so no need to accept this PR if this takes the tool in a direction you weren't planning on going in, but I thought I'd offer the improvements in case you were interested.

Let me know if you have any questions/comments and thanks for starting the tool, it was a big leg up getting the functionality I needed.

Comment thread pages/__init__.py
@@ -0,0 +1,16 @@
# from . pid import *

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import these files explicitly is better?

Comment thread Readme.md
@@ -1,30 +1,35 @@
# FORK

This is a fork of the original repository by beantowel. As such the main branch

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove before pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants