34788 - updated legal api to support tramways - #4791
Merged
Merged
Conversation
meawong
approved these changes
Sep 17, 2026
kialj876
approved these changes
Sep 18, 2026
kialj876
left a comment
kialj876
left a comment
Collaborator
There was a problem hiding this comment.
Worth having a test too I think
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#34788
Description of changes:
Updates temporary business number checks in legal-api so real tramway businesses (TMY + 7 digits, for example TMY0000008) are not treated as temp bootstrap IDs.
Temp registrations also start with T, and some random temps can even start with TMY (although super low probability), so a plain startswith("T") / startswith("TMY") check is too broad.
The endpoints now treat an identifier as temporary only when it starts with T and does not match
^TMY\d{7}$Example:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).