33246 update imports for changes to business account - #4438
Merged
kialj876 merged 3 commits intoMay 28, 2026
Merged
Conversation
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Mechanical import update across multiple services/jobs to consume AccountService from the business_account package root (previously imported from the submodule path business_account.AccountService). Accompanying version bumps and lockfile regenerations pin business-registry-account to 0.1.1.
Changes:
- Replace
from business_account.AccountService import AccountServicewithfrom business_account import AccountServicein 6 services/jobs and related tests. - Bump each affected service/job version and regenerate poetry.lock files to pin
business-registry-accountto 0.1.1. - Minor author metadata change in
update-colin-filings/pyproject.toml.
Reviewed changes
Copilot reviewed 18 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| queue_services/business-filer/src/.../business_info.py | Import update |
| queue_services/business-filer/pyproject.toml | Version bump |
| queue_services/business-filer/poetry.lock | Lock to business-registry-account 0.1.1 |
| queue_services/business-emailer/tests/unit/test_worker.py | Test import update |
| queue_services/business-emailer/tests/unit/test_worker_dispatch.py | Test import update |
| queue_services/business-emailer/tests/unit/test_services_namex.py | Test import update |
| queue_services/business-emailer/src/.../services/namex.py | Import update |
| queue_services/business-emailer/src/.../resources/business_emailer.py | Import update |
| queue_services/business-emailer/pyproject.toml | Version bump |
| queue_services/business-emailer/poetry.lock | Lock regen + 0.1.1 |
| queue_services/business-bn/src/.../registration.py | Import update |
| queue_services/business-bn/pyproject.toml | Version bump |
| queue_services/business-bn/poetry.lock | Lock regen + 0.1.1 |
| gcp-jobs/update-legal-filings/src/.../worker.py | Import update |
| gcp-jobs/update-legal-filings/pyproject.toml | Version bump |
| gcp-jobs/update-legal-filings/poetry.lock | Lock regen + 0.1.1 |
| gcp-jobs/update-colin-filings/src/.../worker.py | Import update |
| gcp-jobs/update-colin-filings/pyproject.toml | Version bump + author metadata |
| gcp-jobs/update-colin-filings/poetry.lock | Lock regen + 0.1.1 |
| gcp-jobs/filings-notebook-report/src/.../notebookreport.py | Import update |
| gcp-jobs/filings-notebook-report/pyproject.toml | Version bump |
| gcp-jobs/filings-notebook-report/poetry.lock | Lock regen + 0.1.1 |
| gcp-jobs/email-reminder/src/.../worker.py | Import update |
| gcp-jobs/email-reminder/pyproject.toml | Version bump |
| gcp-jobs/email-reminder/poetry.lock | Lock regen + 0.1.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
loneil
approved these changes
May 27, 2026
loneil
left a comment
loneil
left a comment
Contributor
There was a problem hiding this comment.
Import changes and version updates look good. Noted dissolution and furnishing proj updates to come.
CI fails are just already existing code coverage gaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#33246
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).