Iam changes jacky 2559 - #4167
Closed
Jacky-Pham wants to merge 12 commits into
Closed
Jacky-Pham wants to merge 12 commits into
Jacky-Pham wants to merge 12 commits into
Conversation
I added a sonar exception for config in each job since every job is unique aside from the connection function, creating a helper function would also create abstraction and a dependency. This seems to be an industry accepted practice.
Seems the coverage I was having issues with were from older code from a previous commit. Since my code was added the coverage went below 80% and tests specific to my IAM changes would not have brought it past 80%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created IAM capability with user:pass fallback, Includes Alembic flow for correct ownership, unit tests pass locally, API, Services, Jobs have all been edited with the pattern