Modify ben statement notebooks - #4131
Closed
ketaki-deodhar wants to merge 55 commits into
Closed
ketaki-deodhar wants to merge 55 commits into
ketaki-deodhar wants to merge 55 commits into
Conversation
…ations (…" (bcgov#4132) This reverts commit 3db205e.
Signed-off-by: Lucas <lucasoneil@gmail.com>
Signed-off-by: Lucas <lucasoneil@gmail.com>
ketaki-deodhar
marked this pull request as ready for review
March 5, 2026 18:20
* Business API/model - liquidation report updates Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: fix lint Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: update common model with missed api model change Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* Flag for CoD backdating Signed-off-by: Lucas <lucasoneil@gmail.com> * Fix from review Signed-off-by: Lucas <lucasoneil@gmail.com> --------- Signed-off-by: Lucas <lucasoneil@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* Business Filer - liquidation processing updates Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: improve test Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: ruff fix Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: reduce duplication Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: sonar cloud fixes Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
…d businesses (bcgov#4140) * 32736 Update /search/affiliation_mappings endpoint to support migrated businesses * updated business identifer logic * updated * updated query filters for colin firms * updated test --------- Co-authored-by: Rajandeep <rajandeep.kaur@gov.bc.ca> Co-authored-by: Rajandeep Kaur <144159721+Rajandeep98@users.noreply.github.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
* 31783 - Update common postal code validation and unit tests * 31793 - Update regex pattern and unit tests * 31783 - Update unit tests * 31783 - Update assert statements in test_validate_incorporation_address_whitespace * 31798 - Update COD tests * 31798 - lint fix * 31783 - Update regex patterns and tests * 31783 - Update validation error message + unit tests to reflect new message
Signed-off-by: Doug Lovett <doug@diamante.ca>
bcgov#4148) * Business API - correction updates to support relationships schema and liquidators/receivers, liquidator tweaks Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * Business Model - update registry schemas Signed-off-by: Kial Jinnah <kialj876@gmail.com> * Add relationship handling in correction reports Signed-off-by: Kial Jinnah <kialj876@gmail.com> * add lear_only column on filings model Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: ruff fix Signed-off-by: Kial Jinnah <kialj876@gmail.com> * Update test and remove unnecessary code based off lear_only col Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Doug Lovett <doug@diamante.ca>
Signed-off-by: Doug Lovett <doug@diamante.ca>
Signed-off-by: Doug Lovett <doug@diamante.ca>
Signed-off-by: Doug Lovett <doug@diamante.ca>
Signed-off-by: Doug Lovett <doug@diamante.ca>
…ers-update Colin Data Migration active officer updates.
* 32669 Business filer - update corrections to handle relationships Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: ruff fix Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: address sonar cube comment Signed-off-by: Kial Jinnah <kialj876@gmail.com> * address pr comment Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
…gration Business API - DRS API integration.
* Business API: 32670,32568 - small updates Signed-off-by: Kial Jinnah <kialj876@gmail.com> * chore: cleanup Signed-off-by: Kial Jinnah <kialj876@gmail.com> * tweak in_dissolution to be allowed for businesses that require a prta filing Signed-off-by: Kial Jinnah <kialj876@gmail.com> --------- Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Doug Lovett <doug@diamante.ca>
…-update Business API rename ledger docs property UI issue.
Signed-off-by: Doug Lovett <doug@diamante.ca>
Signed-off-by: Doug Lovett <doug@diamante.ca>
…-update2 DRS fix filename from report meta issue.
Signed-off-by: Doug Lovett <doug@diamante.ca>
…-filings Business API fix temp filing retrieve outputs issue.
Signed-off-by: Doug Lovett <doug@diamante.ca>
…rt-config Business API update report configuration for missing alteration.
Signed-off-by: Doug Lovett <doug@diamante.ca>
…rt-binary Business API requests DRS binary data instead of download link.
… submitting party (bcgov#4197)
…har/lear into modify-ben-sttement-notebook
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4131 +/- ##
==========================================
- Coverage 29.66% 29.58% -0.08%
==========================================
Files 39 39
Lines 3486 3556 +70
==========================================
+ Hits 1034 1052 +18
- Misses 2452 2504 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
closing PR. Working on a new one as had to rework on set up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
Description of changes:
Updated all notebooks to use python kernel 3.11. Logic did not change at all.
The changes are related to connecting to the db, updating to use the python kernel 3.11
Tested successfully in Test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).