Skip to content

include_object_timerange improvements#215

Merged
j616 merged 3 commits into
mainfrom
jamessa-objectTimerange
Jun 26, 2026
Merged

include_object_timerange improvements#215
j616 merged 3 commits into
mainfrom
jamessa-objectTimerange

Conversation

@j616

@j616 j616 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Details

  • Add include_object_timerange option to webhooks, to match HTTP API
  • Always return object_timerange when include_object_timerange is true
    • Fixes slightly confusing behaviour where it was omitted if it matched the Flow Segment's timerange

Issue (if relevant)

GitHub Issue: #203
Jira ticket: https://jira.dev.bbc.co.uk/browse/CLOUDFIT-5544

Related PRs

Submitter PR Checks

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner June 15, 2026 15:21
@j616 j616 linked an issue Jun 15, 2026 that may be closed by this pull request

@samdbmg samdbmg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j616 j616 merged commit 59bb925 into main Jun 26, 2026
8 checks passed
@j616 j616 deleted the jamessa-objectTimerange branch June 26, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

object_timerange missing from webhooks

2 participants