Repository navigation
fix(popup-menu): honour filter on data-first surfaces - #601
Merged
kianbazza merged 1 commit intoOct 28, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data-first surfaces declared
filterbut never used it: the surface set the store's filter tofalsein data mode, and the list scored rows withcommandScoreregardless. The surface'sfilternow reaches scoring.filter={false}turns filtering off, as in the composable API: rows render as they do with no search (no deep results, branch loaders stay disabled), whileasyncContentquery loaders still get the search. That fitscontentyou filter yourself, or a loader that filters on the server.Evidence
filter={(value, search) => value.includes(search) ? 0 : 1}, searching "an", showed only Banana (thecommandScoreresult). Withfilter={false}, searching "cherry" showed only Cherry.After: the same search shows Apple, Cherry and the deep result Kiwi, and hides Banana.
filter={false}shows every row.data-list.test.tsx›surface filter(2) andasync-content-reveal.test.tsx›filter={false} still sends the search to the query loader, and keeps local rows unfiltered. All three fail without the change.bun run check,bun run type-check,bun run test --filter @bazza-ui/react(1532 passed).Merge Danger
Door: two-way
Blast Radius: small
Data-first surfaces that already passed a custom
filternow get its scores instead ofcommandScore. Ones that passedfilter={false}now show every row unfiltered, where before they filtered withcommandScore.