Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kianbazza
force-pushed
the
ui-640-re-render-only-rows-whose-visibility-changes-while-filtering
branch
from
October 10, 2026 23:33
41a53bb to
f695de5
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each row subscribed to the whole search string, so every keystroke re-rendered every mounted row. Rows now subscribe to a boolean, so only rows whose visibility flips re-render.
isItemVisibleandhasSearchare new store selectors.getItemScoreandnormalizedSearchstay, since the store is public asDropdownMenuStoreand friends.Evidence
row-renders.test.tsx› "re-renders only rows whose output changes while filtering": 20 items and analwaysRenderseparator, each wrapped in a<Profiler>.AssertionError: Item 01: expected 7 to be 4After: passes
Merge Danger
Door: two-way
Visibility follows the same rule as before: no search, filtering disabled,
forceMount, or a positive score.Blast Radius: small
Touches every menu family's rows (items and separators). A wrong selector would show up as rows not hiding or not reappearing while filtering, which the existing filtering tests cover.
Closes UI-640