Validate download symlink targets stay within the output directory#657
Closed
adilburaksen wants to merge 1 commit into
Closed
Validate download symlink targets stay within the output directory#657adilburaksen wants to merge 1 commit into
adilburaksen wants to merge 1 commit into
Conversation
DownloadOutputs creates symlinks from output trees using the SymlinkTarget value returned by the server. The target was used verbatim, so a server could return a symlink whose target is an absolute path or uses '..' to point outside the output directory, creating links to arbitrary locations on the client filesystem. Reject symlink targets that resolve outside outDir before creating the link. This mirrors the containment already applied to output paths.
Author
|
Closing in favor of #650, which addresses the same unvalidated download symlink target and additionally covers the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadOutputs(go/pkg/client/cas_download.go) creates symlinks from output trees using theSymlinkTargetvalue returned by the server, used verbatim. A server could therefore return a symlink whose target is an absolute path or uses..to point outside the output directory, creating links to arbitrary locations on the client filesystem.This rejects symlink targets that resolve outside
outDirbefore the link is created, mirroring the containment already applied to output paths. Targets that stay within the output directory are unaffected.