fix: labelsToWatch short-circuiting faster than it should#826
Open
markovejnovic wants to merge 2 commits into
Open
fix: labelsToWatch short-circuiting faster than it should#826markovejnovic wants to merge 2 commits into
markovejnovic wants to merge 2 commits into
Conversation
Member
|
Hey @markovejnovic. Love the contribution. Can I have you put together an e2e test that can be included in the repo which demonstrates this behavior so that we don't regress going forward? |
Author
|
Of course! I'll try to get to it soon! Sorry I didn't reply earlier! |
added 2 commits
May 23, 2026 09:42
Extract resolveLabels as a standalone pure function from labelsToWatch
for testability. Add TestResolveLabels with 6 subtests — last two
("local repo match does not stop processing subsequent labels" and
"multiple local repo matches all resolved") fail, proving the break
bug silently drops labels after the first @repo match.
Member
|
I'd very much like to see an e2e test attached to this. Unit tests don't really demonstrate the issue since it's so easy to accidentally encode an incorrect assumption about the world |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #825. Please read that ticket as I don't really understand the intent behind this function nor its role in the larger application.