Skip to content

Tell a stale resume token from one that was never valid - #7

Merged
liran merged 2 commits into
mainfrom
feat/tell-gone-steps-from-bad-tokens
Nov 5, 2026
Merged

liran merged 2 commits into
mainfrom
feat/tell-gone-steps-from-bad-tokens

Conversation

@liran

@liran liran commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Resuming with an old token and resuming with garbage both come back as a resume token error, so a callback handler has to answer them the same way. The first is usually a late callback to ignore, and the second is a caller bug to report.

IsStaleResumeTokenError covers only the first. IsResumeTokenError keeps its meaning, so existing callers see no change.

@liran liran self-assigned this Nov 5, 2026
@liran liran changed the title Tell a step that has ended from a resume token that was never valid Tell a stale resume token from one that was never valid Nov 5, 2026
@liran
liran force-pushed the feat/tell-gone-steps-from-bad-tokens branch from 0f2878d to a0669a3 Compare November 5, 2026 15:01
@liran
liran merged commit 51f216b into main Nov 5, 2026
4 checks passed
@liran
liran deleted the feat/tell-gone-steps-from-bad-tokens branch November 5, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant